This is searchable archive of our old support forums, which operated from 2012 - 2016. To find out how to get support for your current theme, please visit our support page.

Specifying a width and height for all images

  • Creator
    Topic
  • #25040
    rohmer
    Member

    Your testimonial slider does not indicate the size of ‘author-image’.
    Same issue on ‘Simple slider’ on CSS class ‘item’.

    Specifying a width and height for all images allows for faster rendering by eliminating the need for unnecessary reflows and repaints.

Viewing 1 replies (of 1 total)
  • Author
    Replies
  • #25054
    Jason Bobich
    Keymaster

    Hi,

    I disagree in doing it for all images, but I can see how it would make sense in something like the simple slider that has large images. However the bigger issue is that those images do not have dimensions saved to them when the slider outputs. And the theme works in a way where it avoids several potential database queries by working off all the image data it needs being present in a meta data array saved from the builder, opposed to actually querying data from WordPress for every image. So to add that isn’t a simple thing and it would require re-evaluating several things starting from the JavaScript in the layout builder that works with media modal window, to saving dimensions with the images, to handling them correctly on the frontend, accounting for those that may then have the old data structure saved.

Viewing 1 replies (of 1 total)
  • You must be logged in to reply to this topic.