RTL Bugs and other stuff

[royeyal]

Hi there
I’ve encountered several bugs with RTL, and some other stuff on this theme (which applies to JumpStart as well).
I apologize in advance for this huge list,

1. There are 2 arrow icons on top of each other

I fixed using

.rtl .tb-thumb-link.post::before {
	content: "";
}

2. Columns shortcode does not support RTL
There’s only this code, no RTL version:

.col-sm-1, .col-sm-2, .col-sm-3, .col-sm-4, .col-sm-5, .col-sm-6, .col-sm-7, .col-sm-8, .col-sm-9, .col-sm-10, .col-sm-11, .col-sm-12 {
	float: left
}

instead of this:

.col-sm-1, .col-sm-2, .col-sm-3, .col-sm-4, .col-sm-5, .col-sm-6, .col-sm-7, .col-sm-8, .col-sm-9, .col-sm-10, .col-sm-11, .col-sm-12 {
	float: right;
}

3. The admin is broken on RTL.
I’ve had to code and load the following CSS in the admin area for me to be able to even see the Layout Builder elements:
http://pastie.org/private/fd8meu2qhnzzbyrfjvdw

4. Post filter does not support non-latin character slugs
I can’t force my clients to use latin slugs for categories.

[Error] Error: Syntax error, unrecognized expression: .filter-%d7%a7%d7%a8%d7%95%d7%a1%d7%a4%d7%99%d7%98-%d7%a1%d7%98%d7%a8%d7%95%d7%a0%d7%92%d7%9e%d7%9f

5. Block button hover mode is set to inline-block
Even if the button is set to be in full width mode (block),
the hover state is defined as inline-block, rather than block
This is your code:

.btn:hover {
	display: inline-block;
}

6. Non RTL issue: broken links on your dev site
on Default Template Parts and many others all the links have this [permalink%20id= suffix:
http://dev.themeblvd.com/tutorial/editable-content-files/%5Bpermalink%20id=

7. It’s not a bug, it’s a feature: Features images as links
Features images on Post List and Blog elements aren’t clickable until you install the Theme Blvd Featured Image Link Override plugin.
This is redundant in my opinion.

8. It’s not a bug, it’s a feature: Button element in the Builder
Why isn’t there a button element in the Builder?
How do I create a simple button using the layout builder?

9. It’s not a bug, it’s a feature: No YouTube/Vimeo support for background video
Why can’t I add a video from YouTube? Why does my client have to use mp4 and WebM files?

10. It’s not a bug, it’s a feature: Revolution Slider scripts
Why do the Revolution Slider scripts load, even though I don’t have it installed at all?
is there a way to make sure several scripts, such as this one, won’t laod?

jquery.themepunch.revolution.min.js

I’m trying to make the theme as lean as I can.

I do hope solving these issues will make the theme better.

• This topic was modified 7 years, 4 months ago by royeyal. Reason: Missed one numbering

Topic

[Jason Bobich]

1. There are 2 arrow icons on top of each other

Good find. This was just a simple typo in the theme’s RTL stylesheet. Fixed for the next update.

2. Columns shortcode does not support RTL

This is a little more complicated than that because these classes and grid system are used for sidebar layouts, as well. In other words, when your site is in RTL, you still want the “Right” sidebar layout to show the sidebar on the right.

But with that said, I think I’ve got this worked out for the next update, and figured out a way to isolate the RTL adjustments to just the column shortcodes and columns element of layout builder, leaving the general grid system for sidebar layouts in-tact.

3. The admin is broken on RTL.

Ok, I’ve gone through and made a lot of improvements to this. It’s looking a lot better. Here are some screenshots of what it’s looking like now:

http://www.uploadblvd.com/uploads/image_564ba49fe7674.png

http://www.uploadblvd.com/uploads/image_564ba4aed3919.png

You’ll see these improvements in the following updates, when they’re published:

1. Denali 1.0.4
2. Jump Start 2.0.4
3. Theme Blvd Layout Builder 2.0.9.4
4. Theme Blvd Widget Areas 1.2.5

Note: I just posted an update to Denali on November 11, and so I’ve got hold of a little before posting this next one.

4. Post filter does not support non-latin character slugs

This is a tough one, and through my limited understanding of non-latin characters, I think I’ve got this worked out for the next update:

http://www.uploadblvd.com/uploads/image_564bb365f11d8.png

I took the same approach I took from when we talked about a similar issue with this while back in regards to the Theme Options page tabs, that being to basically just to sanitize out all of the % so you get a class like filter-d7a7d7a8.

5. Block button hover mode is set to inline-block

Looks like just another simple typo in the Denali theme’s stylesheet (not framework or Jump Start). Fixed for the next update.

6. Non RTL issue: broken links on your dev site

Yeah, since I posted Jump Start 2 (and now Denali most recently), the entire dev site still needs work. A lot articles need some attention. I’ve been chipping away at it.

7. It’s not a bug, it’s a feature: Features images as links

You don’t need the plugin for featured images to be linked. — Similarly to how you must set a featured image on every post, you also must set how that featured image links under the “Post Options” when editing the individual post. The theme framework has worked like this for years now.

For the small group of people that strongly don’t like this, and want a global option to control this, I created that plugin. However, this functionality will probably never change in the framework by default (or not any time soon). Even if I did think it should work differently, a change like this would effect thousands of customers, and just isn’t too realistic, at this point.

8. It’s not a bug, it’s a feature: Button element in the Builder

I would put the button in a similar category to many other items that you can mix within your content using shortcodes, and I don’t believe it warrants its own top-level element.

So, to answer your question, using the [button] shortcode within a content element would be a way to utilize the button element within the builder, for example.

It’s a little hidden, but the WordPress editor and shortcode generator are accessible there: http://www.uploadblvd.com/uploads/image_564ba7e316bf6.png

9. It’s not a bug, it’s a feature: No YouTube/Vimeo support for background video

The background video is a new feature to the framework, and I plan to continue improving it. Adding support for Vimeo and YouTube require additional development. In addition, I want to improve background video to allow streaming (or progressive loading) so that longer length videos can be used without the user having to wait for them to load fully before they start playing. It’s definitely all still a work in progress.

10. It’s not a bug, it’s a feature: Revolution Slider scripts

Hm, not sure what’s going on there. I can promise you this script you’re referencing doesn’t exist anywhere in the theme. The only thing the theme (and layout builder) does is add basically a blank element that just allows Revolution slider to do its thing within, if it exists.

So, I’d check again what you’re doing there on your end. Maybe some sort of caching issue, if you previously had the plugin activated? Or from another plugin you’re using?

[royeyal]

I highly appreciate all your effort addressing each and every of my issues.
I hope you’ll be able to push these updates soon enough, as I am working on a project these very days.

4.) Great solution!

8.) I still think the builder needs a button elements, but I was utterly surprised at the hidden visual editor. It’s just what I’ve been searching for! 🙂

9.) I do hope you’ll find a solution. I have to use a YouTube video as a full screen background, and I hope I won’t have to deal with this.

10.) regarding the Revolution Slider scripts, I was looking at you demo site, not my dev site. So, my bad. Sorry.

3 other things I want to add:

Stretched Header Style
I think the default should be that header should match content width, even if stretched. The current default option to have the elements in the header to be always be placed at the browser window’s edge should be an option in my opinion.
For the project I am working on I had to use this code:

#branding .wrap {
	max-width: 1150px;
}
.site-header.full-width > .wrap .header-logo,
.rtl .site-header.full-width > .wrap .header-logo {
	right: auto;
	left: auto;
}

Having 2 different headers when choosing sticky header
I don’t understand why the sticky header is different.
I had to create my own sticky header for this project:

#top {
	position: fixed;
	margin: auto;
	z-index: 501;
	width: 100%;
}
#custom-main,
.epic-thumb.fs {
	padding-top: 87px;
}

Button
I think all .btn classes should default to 1em, and not 11px.

And that’s it.
Thanks for everything, and for creating such an awesome framework.

Cheers

• This reply was modified 7 years, 4 months ago by royeyal. Reason: typo

[Jason Bobich]

Thanks for the additional feedback. Honestly I personally disagree with the last three points — not in general, but just in terms of making the changes in the theme, itself — but I totally get where you’re coming from on all of them. And it’s awesome to see all of the desired results were easily achieved through basic child theme customization for you.

[royeyal]

Indeed. I’m just sharing my customizations.
Again, thanks for the support.

[Author]

Replies