This is searchable archive of our old support forums, which operated from 2012 - 2016. To find out how to get support for your current theme, please visit our support page.

Options framework vs. MP6

  • Creator
    Topic
  • #12839
    karlo
    Participant

    A tiny little thing:

    Radio buttons are slightly misaligned when MP6 is used.

    #optionsframework input[type="radio"] {
        margin-top: 0px;
    }

    helps and I assume there is more. I know one: check boxes for “Exclude Categories” on Content tab. But only started to play with back end stuff.

    Actually this also goes for same button in post meta boxes.

    Real reason for posting is this http://www.wptavern.com/breaking-new-features-selected-to-merge-into-wordpress-3-8-core which means MP6 is going in WP 3.8. So if someone have been “what ever” about MP6 it is now time to adjust šŸ™‚

    If they keep old theme as optional then may be 2 sets of fixes required? Can use .mp6 body class perhaps. There are plugins doing CSS stuff to admin = some will not change to MP6 as it “breaks”. After latest color schemes I think most will prefer MP6 if possible.

Viewing 15 replies - 1 through 15 (of 15 total)
  • Author
    Replies
  • #12840
    karlo
    Participant

    Just had a thought. I seem to assume MP6 is finalized but officially it wont be until out the door with 3.8. Is that not how it works? Why they would change values for default elements I do not know but cant be 100% sure. But now it has been talked about on Jump Start forum šŸ™‚

    #12843
    Jason Bobich
    Keymaster

    Hi Karlo,

    My plans on this were to wait until there’s a later beta version of 3.8 (which sounds like it won’t be too far away) and then make everything admin-related in the framework go with it and match aesthetically. I’m not planning on doing anything now for just the MP6 plugin because I know this will continue to change. I don’t want another post formats debacle; so much time wasted on that.

    #12844
    karlo
    Participant

    I understand. Even though Mullenweg says devs. must “up their game” may be complaints will start to come in as beta gets out – and then changes could happen. I have gotten used to it last few weeks so think of MP6 as default, not so yet.

    #13133
    Jason Bobich
    Keymaster

    Have you seen any where if they’ve said they’re planning to keep the “mp6” class on the <body> when they implement it into core?

    #13134
    karlo
    Participant

    Nope. I see this http://plugins.trac.wordpress.org/ticket/1862 and a quote from http://make.wordpress.org/ui/tag/mp6/

    If you want to check if MP6 is activated, use the MP6 PHP constant. In CSS use mp6 body class, not admin-color-mp6, Iā€™m looking at you Jetpack.

    but they almost have to keep it as other plugins, may be those doing stuff in admin bar, will have to adjust. Might not be easy to make CSS working 100% on old default and new MP6. Thing is also responsive with mobile icon and all.

    I would not rely on written statements unless official and that will only be the case after release. They can go back on anything. May be better to check relevant IRC channel? Ask directly in their face. http://irclogs.wordpress.org/ Check who is in UI team then you can validate answer. I do not use IRC but this is actually where all the devs. hang out, from top brass and down.

    #13135
    karlo
    Participant

    Snippet from my cache plugin, it has begun šŸ™‚

    body:not(.mp6) #wp-admin-bar-cachify a.ab-item span {
    	display: none;
    }
    #13159
    karlo
    Participant

    Hmm, seems I was guessing wrong about backwards compatibility. I doubt there will be any. Tried latest “Nightly” where MP6 has been baked in. There is NO .mp6 body class I can see. Now only class for color scheme in back-end. There are different color schemes but all seem to be MP6 now.

    If true only reason to mess with old CSS is to support WordPress < 3.8 I would skip that and tell such installs to upgrade or install MP6 plugin šŸ™‚ But easy to say…

    So right now CSS from my cache plugin fails but of course he assumes I use MP6 plugin.

    #13165
    Jason Bobich
    Keymaster

    Yeah, I was working on this yesterday and saw the same thing. I think I’m just going to add it like this:

    function themeblvd_mp6( $classes ) {
    
    	global $wp_version;
    
    	// If not WordPress 3.8+, do nothing
    	if ( version_compare( floatval( $wp_version ), '3.8', '<' ) ) {
    		return $classes;
    	}
    
    	// If "mp6" class exists already, do nothing
    	if( false !== strpos( $classes, 'mp6' ) ) {
    		return $classes;
    	}
    
    	// Add "mp6" class
    	$classes .= ' mp6';
    
    	return $classes;
    }
    add_filter( 'admin_body_class', 'themeblvd_mp6' );

    … At least until WP 3.9 comes out. I don’t want there to be an abrupt change where the theme only works with 3.8 and nothing before.

    #13166
    karlo
    Participant

    Seems wise. Just because there are auto update feature does not mean everyone will update. Cannot assume much.

    Not sure how big an issue it is with Jump Start, I only stumbled over those form elements. Might be bigger deal for other plugins. Especially those who have been creative šŸ™‚ Depends on eyes but I think non-core style will stand out more with MP6 than before. And double that when most come to expect responsive perfection. Random or old CSS code wont magically work well at low res.

    #13168
    karlo
    Participant

    Almost official burial of that class https://twitter.com/Rarst/status/402181651439972353 – as of today.

    That class was for targeting a plugin, fin.

    She and others in that chitchat are in UI team. Or is it only her? Think 2 of them are in teams at least – so ok to be confused here as well, heh. But fin is fin!

    #13210
    karlo
    Participant

    You better keep eye on this thread by Nacin http://make.wordpress.org/ui/2013/11/19/targeting-the-new-dashboard-design-in-a-post-mp6-world/ I see first comment is a question, heh.

    #13211
    Jason Bobich
    Keymaster

    Thanks, will definitely keep an eye n that. But it looks like my initial thought of just adding the mp6 body class will do the trick.

    #13214
    karlo
    Participant

    Yes no problems. I wonder if they could not increase quality of communication by having a “Dev Journal”? Those make pages are a bit like that but also for discussion. Some will skip! In this case he is laying down the law but if thread become 2 mile long with lots of obvious better suggestions then what would it end up with? Still 100% sure they do not change anything? Journal should not have comments but simply state relevant facts and decisions, no fluff. With no controversy. This about mp6 class should be mentioned/listed. Apparently those involved have zero doubts – those outside can have or at least speculate! May be done on a weekly basis. Should be IRC/TRAC/Twitter chitchat/Make pages for the lazy or for the person who do not like he says, oh I think she is in the UI team and she says.

    #13231
    Jason Bobich
    Keymaster

    Yeah, I think overall the way people get involved can be a little intimidating with how they have it setup. I don’t think that is their intention because they are always talking about at WordCamps what they can do so it’s easier for more people to get involved.

    #13232
    Jason Bobich
    Keymaster

    For anyone curious, I’ve been working on this the last few days, and here are some screenshots with how the framework and big plugins are integrating with MP6 and WordPress 8 alpha:


    And also a new icon font I created is included throughout the admin:

Viewing 15 replies - 1 through 15 (of 15 total)
  • You must be logged in to reply to this topic.