Jetpack / Jump Start conflict
-
Topic
-
Hi Jason,
With JS 2.0.3, Jetpack Contact Forms lightbox interface isn’t loading its normal content — it won’t let you add fields. It worked fine on previous versions of JS, though I don’t know which version it broke on.
Jetpack works fine with TwentyFifteen theme. Worked fine with latest versions of TB plugins, but stopped working when I updated JS to 2.0.3. A few other people are having same issue.
http://postimg.org/image/8i3gh6t2h/
Thanks!
Angela
-
Replies
-
Yes, that was fun figuring out. Apparently for whatever reason, because I named a variable “scroll” in the javascript — it was breaking JetPack. Fixed for the next Jump Start update.
Hi, I tried this fix on a few sites, cleared the browser cache and cache and tried new browser, and it still isn’t working. Not sure what I’m missing. Thanks!
I’m not quite sure what you’ve done with the files. I see shared.js minified, and it doesn’t match shared.min.js. And in the file that’s actually used (shared.min.js) I can see where you haven’t made the change:
See screenshot: http://www.uploadblvd.com/uploads/image_5654d9e5a8fcf.jpg
Put the original shared.js file back from the theme. Make the specific four changes outlined in the screenshot above to shared.js. Then create a minified version of shared.js that is named shared.min.js.
Okay, that’s funny, because that’s exactly what I did except I accidentally saved my minified version to the shared.js.
I changed the scroll= in the four places, minified the file using Coda, and replaced the minfiied file that was there. I just rechecked my minified version, and the changes are all there. So, that’s weird that you could see one that wasn’t. It is changed in the four places.
However, what I did notice is that when I disabled plugins, the problem resolved. I could repeat the problem on another site with some plugins activated.
I won’t be testing on AskWPGirl because I have CloudFlare enabled, so that might be messing up which file is being served. I created a staging area to test plus I have another site on another host to compare to, so I’ll send you new login for that once I’ve narrowed it down.
I’ll keep you posted. Thanks for checking. Sorry for the confusion with that file. So weird.
One other question, how do you minify your files? Do you use Coda to do it? I noticed your minified version did not have the scroll code in four places — only in two. Was that a result of minification? It was puzzling to me. That’s why I duplicated shared.js after I fixed it and minified it myself.
However, what I did notice is that when I disabled plugins, the problem resolved. I could repeat the problem on another site with some plugins activated.
Yeah, I would try to determine what is actually causing the conflict.
I can tell you that on my end when I isolated a local site to just Jump Start and JetPack, the error in my Chrome dev console I was trying to fix was a specific one. — It was something along the lines of, “jQuery.scroll is not a function.” So, if you’re seeing a different javascript error than that in your browser’s dev console, you may be seeing a separate conflict.
One other question, how do you minify your files?
I use a program Atom (made by GitHub) as my code editor, and I have this extension installed with it.
I noticed your minified version did not have the scroll code in four places — only in two.
There’s a lot of different minify engines out there that work in different ways. My particular one (I think) attempts to actually shorten various variables and other erroneous text to further compress the file size. For example, if it finds two specific instances of
var fooand can make the connection, it may change it tovar a.But at this point, the minification isn’t really even important if that’s tripping you up. It’s a super, super, minor detail in the overall optimization of your WordPress admin. You can just copy all of shared.js to shared.min.js, unedited — it doesn’t really make a difference.
- You must be logged in to reply to this topic.